Conversation
code-crusher
commented
Feb 3, 2026
code-crusher
commented
- fix multi-window auth sync
- update changelog
|
Summary By MatterAI
🔄 What ChangedImplemented cross-window synchronization for secrets and extension state. Added event listeners for VS Code secret changes and window focus events to trigger automatic state refreshes in the webview. 🔍 Impact of the ChangeEnsures a consistent user experience across multiple VS Code windows. When authentication tokens or settings are updated in one instance, all other active instances will automatically synchronize their state, preventing stale data and manual refresh requirements. 📁 Total Files ChangedClick to Expand
🧪 Test Added/RecommendedRecommended
🔒Security VulnerabilitiesN/A - The changes utilize the official VS Code ContextThis PR addresses state drift between multiple VS Code windows by listening to global secret changes and window focus events. Implementation
Screenshots
How to Test
Get in TouchAxon Code Discord: @matterai-agent ⏳ Estimated code review effortLOW (~10 minutes) Tip Quality Recommendations
♫ Tanka Poem
Sequence DiagramsequenceDiagram
participant VS as VSCode Host
participant CP as ContextProxy
participant P as ClineProvider
participant W as Webview
Note over VS, CP: Secret Change Flow
VS->>CP: onDidChange(secretEvent)
CP->>CP: refreshSecrets()
CP->>P: onSecretChangeCallback()
P->>W: postStateToWebview()
Note over VS, P: Window Focus Flow
VS->>P: onDidChangeWindowState(focused: true)
P->>CP: refreshSecrets()
P->>W: postStateToWebview()
|
![matter-ai-bot[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧪 PR Review is completed: The implementation of cross-window secret synchronization using secrets.onDidChange is the correct approach. However, there are opportunities to improve robustness by adding error handling and removing redundant focus-based refreshes.
Skipped files
CHANGELOG.md: Skipped file pattern
| this.secretsChangeDisposable = this.originalContext.secrets.onDidChange(async () => { | ||
| await this.refreshSecrets() | ||
| if (this.onSecretChangeCallback) { | ||
| await this.onSecretChangeCallback() | ||
| } | ||
| }) |
There was a problem hiding this comment.
🟡 Code Quality
Issue: The event listener for secret changes lacks error handling. If refreshSecrets or the callback fails, it could lead to unhandled promise rejections.
Fix: Wrap the execution in a try-catch block to safely handle any errors during the update process.
Impact: Prevents silent failures and unhandled rejections
| this.secretsChangeDisposable = this.originalContext.secrets.onDidChange(async () => { | |
| await this.refreshSecrets() | |
| if (this.onSecretChangeCallback) { | |
| await this.onSecretChangeCallback() | |
| } | |
| }) | |
| this.secretsChangeDisposable = this.originalContext.secrets.onDidChange(async () => { | |
| try { | |
| await this.refreshSecrets() | |
| if (this.onSecretChangeCallback) { | |
| await this.onSecretChangeCallback() | |
| } | |
| } catch (error) { | |
| console.error("Failed to handle secret change:", error) | |
| } | |
| }) |
| // Multi-window synchronization: refresh secrets when window gains focus | ||
| const windowStateDisposable = vscode.window.onDidChangeWindowState(async (e) => { | ||
| if (e.focused && this.contextProxy.isInitialized) { | ||
| await this.contextProxy.refreshSecrets() | ||
| await this.postStateToWebview() | ||
| } | ||
| }) | ||
| this.disposables.push(windowStateDisposable) |
There was a problem hiding this comment.
🟡 Performance
Issue: The onDidChangeWindowState listener triggers a secret refresh every time the window gains focus. Since secrets.onDidChange (handled in ContextProxy) already provides reliable cross-window synchronization, this focus handler creates unnecessary overhead.
Fix: Remove the redundant focus listener and rely on the event-driven synchronization.
Impact: Reduces unnecessary IPC calls and secret storage reads
| // Multi-window synchronization: refresh secrets when window gains focus | |
| const windowStateDisposable = vscode.window.onDidChangeWindowState(async (e) => { | |
| if (e.focused && this.contextProxy.isInitialized) { | |
| await this.contextProxy.refreshSecrets() | |
| await this.postStateToWebview() | |
| } | |
| }) | |
| this.disposables.push(windowStateDisposable) |
1 participant
